Week 11 - Reviewing with my Cohort

This week, we were tasked with reviewing each other’s files to make sure everyone gets it done properly, even when they are simple. I contacted my group mates in Cohort to exchange our files. Everything was well done; I caught some simple mistakes for my classmates while learning how to write better Javadoc for myself. On the other hand, my classmate mentioned about using toString() of ArrayList rather than Stringbuilder with for loop. I took the feedback but cannot agree to change. Because I need to print out the list of books of reader correctly as required, so toString() method alone won’t be correct.

Questions:

1.      I worked with classmates in Cohort group SoCal Software.

2.      Improvements

3.      Those unit tests were simple, and I didn’t have a hard time completing them.

4.      If I have a chance, I will extend all the test cases furthermore. For now, they cover the basic cases. I would like to move on to the intermediate cases, those near or lie on the boundary of equivalence classes.

5.      I struggled a little bit with prompt and UML Diagram as this is the first time I experienced them. But it didn’t take long for me to get used to them.

6.      Similarly, my teammates didn’t seem to struggle with anything. They what I remember, they also have experience with Java before.

7.      I had a proud moment after finishing the Reader file. At that moment, I realized how valuable my personal projects were, even though I made countless mistakes. However, I learned valuable lessons and became familiar with working on large projects. Therefore, when working on project 01, I didn’t encounter significant problems, and that made me feel proud.

Here is the summary feedback I gave to my classmates

Tariq:

All the tests passed and there are no warnings or unused imports. Variables and methods are divided clearly and documented in detail. However, I think that some Javadoc can be simplified as some of them are not necessary. For example, getters and setters, if nothing changes, are not necessary to be documented in such detail. Or some parameters that people can understand immediately, I don’t think they need to be in Javadoc either.

In addition, please check the method removeBook() as it should have three different returns. The missing one is when the book is failed to remove.

Jason:

All the tests passed and there are no warnings or unused imports. Variables and methods are divided clearly. However, there are no comment and Javadoc. So far, Book and Reader files are simple, they are still easy to read and maintain. However, in the Shelf file, methods start becoming longer and more complicated. As a result, it is necessary to comment and document down to make understanding and maintenance easier in the future.

In addition, double check on override toString() method. It should use cardNumber variable, not the static variable.